search

hyperledger-archives / sawtooth-sdk-cxx

https://wiki.hyperledger.org/display/sawtooth
Apache License 2.0
4 stars 21 forks source link

Fix Incorrect Comment about CheckIfValidNamespace #3

Closed danintel closed 5 years ago

danintel commented 6 years ago

s/Checks if an address string/Checks if a namespace string/

Signed-off-by: danintel daniel.anderson@intel.com

danintel commented 6 years ago

My comment was not addressed in PR #2, so I am making a new PR here.

danintel commented 6 years ago

@EugeneYYY I made the changes you requested.

I also enhanced the exception message to print the invalid length (as is currently done for addresses).

dcmiddle commented 5 years ago

@danintel could you please recreate this PR for the c++ sdk repo? https://github.com/hyperledger/sawtooth-sdk-cxx

danintel commented 5 years ago

@dcmiddle Sure, but what is there to recreate? My repo is still there, the PR is still here, and there have been no conflicting merges, let alone merges in the mean time.

dcmiddle commented 5 years ago

My bad. I was running through a few SDK PRs that were against sawtooth-core. Missed this one was already against the correct repo. I'll ping @EugeneYYY and see if he can ungate this.