search

hyperledger-archives / ursa

Hyperledger Ursa (a shared cryptographic library) has moved to end-of-life status, with the components of Ursa still in use moved to their relevant Hyperledger projects (AnonCreds, Indy, Aries and Iroha).
https://wiki.hyperledger.org/display/ursa
Apache License 2.0
321 stars 142 forks source link

Publish the new version to crates.io #189

Closed askolesov closed 2 years ago

askolesov commented 3 years ago

@ryjones @mikelodder7 Could you please publish the new version to crates.io? It would help us a lot.

ryjones commented 3 years ago

should I wait for #190 to get merged?

askolesov commented 3 years ago

Yes please

askolesov commented 3 years ago

@ryjones Could you please ask someone to approve it?

ryjones commented 3 years ago

@askolesov I asked in chat

ryjones commented 3 years ago

@askolesov is #186 also needed?

askolesov commented 3 years ago

We've already bumped k256 here. p256 doesn't introduce conflicts for us so I suggest publishing the new version now.

askolesov commented 3 years ago

@ryjones Thanks for creating a GitHub release! Can this be also pushed in crates.io?

ryjones commented 3 years ago

@askolesov I have tried to set up an action to publish, but it doesn't work like I expect. Could you help me over here? https://github.com/ryjones/ursa/commit/e90c24b9f1769defb752dbaefdf76449ab66d949 once the action will do a --dry-run successfully then I will move it over here

askolesov commented 3 years ago

Sure I tried to build a package with @Artemkaaas today but it fails with strange errors. We think they were in the previous release as well. @mikelodder7 could you please help us?

brentzundel commented 3 years ago

@askolesov what are the errors? Could you paste them here?

ryjones commented 3 years ago

@brentzundel check out over here: https://github.com/ryjones/ursa/commit/2eaa468f92c8505f8472ed5f36dfbc120302e425#diff-9efc738000935f7d55626940aa06fd013cffe8779f5169b16b50e98331612aa0R3

ryjones commented 2 years ago

@askolesov I think Mike Lodder published it two days ago - confirm?

https://crates.io/crates/ursa/0.3.7

askolesov commented 2 years ago

Yes, thanks a lot!