search

hyperledger-archives / ursa

Hyperledger Ursa (a shared cryptographic library) has moved to end-of-life status, with the components of Ursa still in use moved to their relevant Hyperledger projects (AnonCreds, Indy, Aries and Iroha).
https://wiki.hyperledger.org/display/ursa
Apache License 2.0
321 stars 142 forks source link

Update Time crate #197

Closed dcmiddle closed 2 years ago

dcmiddle commented 2 years ago

Fixes https://github.com/hyperledger/ursa/issues/196

brentzundel commented 2 years ago

looks like the build failed

dcmiddle commented 2 years ago

Build is failing because I missed an instance of time. libsodium-ffi depends on zip depends on the old version of time. This is the latest version of zip. Anyone know how to address this?

hartm commented 2 years ago

This might be a more complicated fix.

It seems like libsodium-ffi hasn't been updated in a while. I'm not sure what the best libsodium wrapper for rust is at this point, either.

brentzundel commented 2 years ago

Would this one work? https://github.com/RustCrypto/nacl-compat

brentzundel commented 2 years ago

there are also many resources here that have been compiled by the rust crypto interest group:https://cryptography.rs/, in particular https://github.com/brndnmtthws/dryoc might work for us.

dcmiddle commented 2 years ago

blocked on https://github.com/zip-rs/zip/pull/254 Note libsodium-ffi is pegged to v0.5 of zip. https://github.com/zonyitoo/libsodium-ffi/blob/master/Cargo.toml#L20 presumably the zip fix comes in with a point release on 0.5.

andrewwhitehead commented 2 years ago

It looks like libsodium-ffi is only used to check the validity of ed25519 and chacha20, and to provide an alternative backend for chacha20 encryption. I would suggest just removing it.

hartm commented 2 years ago

We discussed this issue in yesterday's Ursa meeting. As @andrewwhitehead suggests, the best solution seems to be removing libsodium. Other people in cryptography that I've discussed this with have also recommended that we ditch libsodium. @mac-arrap

andrewwhitehead commented 2 years ago

Is this being worked on?

dcmiddle commented 2 years ago

@andrewwhitehead I was going to dig in later .. maybe tomorrow, but if you already know what needs to be excised feel free to go for it! lemme know.

hartm commented 2 years ago

Cam @mac-arrap said he was going to look at it. You should feel free to take a peek yourself, but it would be great if you could include him as well. Obviously, the more the merrier!

dcmiddle commented 2 years ago

superseded by https://github.com/hyperledger/ursa/pull/200