hyperledger-archives / ursa

Hyperledger Ursa (a shared cryptographic library) has moved to end-of-life status, with the components of Ursa still in use moved to their relevant Hyperledger projects (AnonCreds, Indy, Aries and Iroha).

https://wiki.hyperledger.org/display/ursa

Apache License 2.0

321 stars 142 forks source link

[feature] #224: Ursa bump to edition 2021 and trivial dependencies #225

Closed appetrosyan closed 1 year ago

appetrosyan commented 1 year ago

Simple version bump for all Rust edition 2015 idioms.

Description of change

Applied cargo fix --edition

Issues

Closes #224

Testing

Tests added

No extra tests added

Existing tests

Not altered

Local test runs

Apple M2 - Pending

Discussion

Pros

Able to link with newer libraries
More idiomatic modern Rust

Cons

No longer backwards compatible

Special comments

Change of MSRV

ryjones commented 1 year ago

@brentzundel thoughts?

brentzundel commented 1 year ago

It was my understanding that @appetrosyan was planning to update the reference to Dalek to no longer point at his personal repository. At that point I'm happy to approve and merge.

appetrosyan commented 1 year ago

@brentzundel

It was my understanding that @appetrosyan was planning to update the reference to Dalek to no longer point at his personal repository. At that point I'm happy to approve and merge.

I'm afraid that this is not an option as of yet. To upgrade to dalek-25519 ="2.0.0-rc.2" would require updating non-trivial dependencies. I'm not comfortable breaking the API in main.

ryjones commented 1 year ago

@appetrosyan please see #233