search

hyperledger-bevel / bevel-operator-fabric

Hyperledger Fabric Kubernetes operator - Hyperledger Fabric operator for Kubernetes (v2.3, v2.4 and v2.5, soon 3.0)
https://hyperledger-bevel.github.io/bevel-operator-fabric/
Apache License 2.0
278 stars 93 forks source link

Fix default channel config name #113

Closed ZappaBoy closed 2 years ago

ZappaBoy commented 2 years ago

Creating a server to expose REST API I got this error:

Error: Failed to create Channel. channel name should match Regex /^[a-z][a-z0-9.-]*$/, but got _default

It seems that the underscore in _default is an unsupported symbol, so I solved renaming the default channel in default in all the project. Hope this can help.

P.S.: I think is a good idea to add a "How to contribute" section to explain how to install a custom plugin/operator version to test changes and contribute to the project.

dviejokfs commented 2 years ago

After checking this PR, I think we should parameterized the channels in the resultant network config.

The _default channel is useful for GoLang applications, but for Node.JS applications, it fails as you state.

ZappaBoy commented 2 years ago

After checking this PR, I think we should parameterized the channels in the resultant network config.

The _default channel is useful for GoLang applications, but for Node.JS applications, it fails as you state.

Ok, considering what you said, if you agree with me I think that is better to close the PR (also because it does not pass the tests) and simply open an Issue about that.

dviejokfs commented 2 years ago

Looks good to me @ZappaBoy