hyperledger-bevel / bevel-operator-fabric

Hyperledger Fabric Kubernetes operator - Hyperledger Fabric operator for Kubernetes (v2.3, v2.4 and v2.5, soon 3.0)
https://hyperledger-bevel.github.io/bevel-operator-fabric/
Apache License 2.0
280 stars 93 forks source link

Support for peer hostAliases in create and update #120

Closed minollo closed 2 years ago

minollo commented 2 years ago
adityajoshi12 commented 2 years ago

Q: updating the /etc/hosts file is not a good way, let's think of a better way to enable communication between peers and orderer, Kubernetes services could be one of the ways.

minollo commented 2 years ago

Surely not something you would want to use in production systems; but it is something which makes testing/prototyping with k8s/istio clusters where nodes are private easy. Using k8s hostAliases - as I did here - it abstracts users from what happens (/etc/hosts) under the cover.

dviejokfs commented 2 years ago

Thanks for the PR! Could you implement the same for the orderer nodes?

Also, please, you need to complete the DCO; you can execute the following commands to resolve it:

git rebase --signoff HEAD~10
git push --force
minollo commented 2 years ago

Sure, I'll do the same for ordering nodes tomorrow. I have executed the git commands you suggested.

minollo commented 2 years ago

Added hostAliases support to ordnodes. The code base seems to be in dire need of UTs...

dviejokfs commented 2 years ago

I'm merging the PR, thank you so much @minollo!