hyperledger-bevel / bevel

An automation framework for rapidly and consistently deploying production-ready DLT platforms
https://hyperledger-bevel.readthedocs.io/en/latest/
Apache License 2.0
344 stars 715 forks source link

Custom container registry support #2386

Closed arsulegai closed 11 months ago

arsulegai commented 1 year ago

Describe the bug Currently the Bevel framework has an option to specify the container registry username and password. This information however does not help unless somebody manually updates the default value spec of every container image.

Container images are hardcoded in helm charts as default values. For example: https://github.com/hyperledger/bevel/blob/28ff161b268d5869c131be5c81c86eaebe602e3e/platforms/hyperledger-fabric/charts/peernode/values.yaml#L17 The update on this default value is possible through the HelmRelease, however those updates are not consistent. For example: https://github.com/hyperledger/bevel/blob/28ff161b268d5869c131be5c81c86eaebe602e3e/platforms/hyperledger-fabric/configuration/roles/create/peers/tasks/nested_main.yaml#L27 does not use the specified container image registry. The image for couchdb in the same file does.

To Reproduce Regular workflow of Bevel with a custom container registry.

Expected behavior The ideal solution is to use the container registry URL consistently for all images. Then each release to have a list of pre-requisite images that somebody needs to have to use the Bevel project. Use the container image repository information to arrive at the value spec for the container images.

Screenshots NA

Environment (please complete the following information):

Additional context None

mgCepeda commented 1 year ago

I'll take this issue