search

hyperledger-cacti / cacti

Hyperledger Cacti is a new approach to the blockchain interoperability problem
https://wiki.hyperledger.org/display/cactus
Apache License 2.0
345 stars 285 forks source link

refactor(cmd-api-server): migrate from convict to yargs #1200

Open petermetz opened 3 years ago

petermetz commented 3 years ago

Description

Pros and cons wise yargs wins out based on my recent experience with using both.

Convict cannot express certain things correctly in the configuration schema which makes it slightly harder to understand, specifically when it comes to asking in JSON strings as configuration parameters.

Acceptance Criteria

  1. Convict is no longer a dependency in the project
  2. Configuration parsing works as before, e.g. the existing config.json files, the CLI -> ENV -> FILE predence is kept
  3. API server is able to print it's own command line help message going through all the commands providing examples as before.
Leeyoungone commented 2 years ago

Hello! May I take up this issue?

petermetz commented 2 years ago

@Leeyoungone Of course, all yours! Thank you!