search

hyperledger-cacti / cacti

Hyperledger Cacti is a new approach to the blockchain interoperability problem
https://wiki.hyperledger.org/display/cactus
Apache License 2.0
340 stars 282 forks source link

fix(config-service): config validator throws warnings #1650

Open m-courtin opened 2 years ago

m-courtin commented 2 years ago

Describe the bug

In multiple unit tests the config-validator of the config service throws the following warnings:

Warning: configuration param 'type' not declared in the schema Warning: configuration param 'action' not declared in the schema

The warnings are getting thrown, as the validate function is finding properties on the instances of plugins and the corresponding schema is NOT providing the related schema definition required by the plugin interface.

In detail the "action" and the "type" properties are missing in the plugin schema definition for the type "PluginImport"

m-courtin commented 2 years ago

@petermetz: Can you please assign this issue onto my name

petermetz commented 2 years ago

@m-courtin You got it!

outSH commented 9 months ago

@m-courtin Any update regarding this?

m-courtin commented 9 months ago

Hello Michal,

as I’m now almost 2 years out of the Cactus-Project I’m not able to answer your question.

Please contact Peter Somogyvari. He should be able to help you.

Best Regards, Michael

Michael Courtin

Accenture GmbH Bruesseler Str. 3, 67657 Kaiserslautern, Germany mobile: +49 631 71069000 | e-mail: @.**@.> Join us online [signature_3281859177]https://www.linkedin.com/company/accenture-consumer-goods [signature_4106533173] https://twitter.com/AccentureCPG [signature_4079139906] https://www.youtube.com/watch?v=yOxLiIpt_4U [signature_2643914457] https://www.accenture.com/us-en/service-solutions-consumer-goods Accenture GmbH Sitz: Kronberg. Registergericht: Königstein im Taunus, HRB 5920. Geschäftsführung: Christina Raab (Vorsitzende der Geschäftsführung), Tobias Gehlhaar, Sven Gudehus, Markus Heyen, Antje Hoffmann, Ildiko Kreisz, Corinna Krezer, Marco Lechner, Michael Nolte, Karl Rathgeb, Tobias Regenfuß, Patrick Vollmer u.a.

From: Michal Bajer @.> Date: Thursday, 28. December 2023 at 13:18 To: hyperledger/cacti @.> Cc: Courtin, Michael @.>, Mention @.> Subject: [External] Re: [hyperledger/cacti] fix(config-service): config validator throws warnings (Issue #1650) CAUTION: External email. Be cautious with links and attachments.

@m-courtinhttps://urldefense.com/v3/__https:/github.com/m-courtin__;!!OrxsNty6D4my!-UYeg2Cn0oAS9DuS8qBTHYqBtfDiFlW7FTLKC4iL4YF0nf9KH66I1MU7OCaMPLzs8e8XW6s5v3NjbiQK8i59gf-h12s3j5E$ Any update regarding this?

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/hyperledger/cacti/issues/1650*issuecomment-1871113812__;Iw!!OrxsNty6D4my!-UYeg2Cn0oAS9DuS8qBTHYqBtfDiFlW7FTLKC4iL4YF0nf9KH66I1MU7OCaMPLzs8e8XW6s5v3NjbiQK8i59gf-hzCQmMys$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AVFHRJDNLQOUYPLA6GJEI4DYLVPQ7AVCNFSM5JZIIBJKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBXGEYTCMZYGEZA__;!!OrxsNty6D4my!-UYeg2Cn0oAS9DuS8qBTHYqBtfDiFlW7FTLKC4iL4YF0nf9KH66I1MU7OCaMPLzs8e8XW6s5v3NjbiQK8i59gf-hKuz4Htc$. You are receiving this because you were mentioned.Message ID: @.***>

This message is for the designated recipient only and may contain privileged, proprietary, or otherwise confidential information. If you have received it in error, please notify the sender immediately and delete the original. Any other use of the e-mail by you is prohibited. Where allowed by local law, electronic communications with Accenture and its affiliates, including e-mail and instant messaging (including content), may be scanned by our systems for the purposes of information security, AI-powered support capabilities, and assessment of internal compliance with Accenture policy. Your privacy is important to us. Accenture uses your personal data only in compliance with data protection laws. For further information on how Accenture processes your personal data, please see our privacy statement at https://www.accenture.com/us-en/privacy-policy.

www.accenture.com