search

hyperledger-cacti / cacti

Hyperledger Cacti is a new approach to the blockchain interoperability problem
https://wiki.hyperledger.org/display/cactus
Apache License 2.0
345 stars 285 forks source link

feat(satp-hermes): update message formats to reflect latest SATP core version #2810

Open RafaelAPB opened 1 year ago

RafaelAPB commented 1 year ago

Update message types according to latest draft: draft-ietf-satp-core-02, available at: https://datatracker.ietf.org/doc/draft-ietf-satp-core/

For example, for the Lock Assertion Receipt Message ( section 8.2.), the specification requires a message_type with content: "urn:ietf:satp:msgtype:assertion-receipt-msg".

The current implementation calls the lock assertion receipt as "lock evidence claim": packages/cactus-plugin-odap-hermes/src/main/json/openapi.json (line 269). One needs to change the wording in open-api.json and update it throughout the code.

@petermetz please assign it to me. @AndreAugusto11 and I are managing these tasks.

-- draft-ietf-satp-core-02

petermetz commented 1 year ago

@RafaelAPB Assigned, thank you again!

RafaelAPB commented 1 year ago

@petermetz can i suggest you add a "P" to the label, as in "IETF-SATP"? Thank you!

petermetz commented 1 year ago

@petermetz can i suggest you add a "P" to the label, as in "IETF-SATP"? Thank you!

@RafaelAPB Yup, I renamed it just now! Thanks for the suggestion!

RafaelAPB commented 1 year ago

working with @AkashWarlocks on this

petermetz commented 1 year ago

working with @AkashWarlocks on this

@RafaelAPB I can only assign issues to people who have commented on it, e.g.: I can update the assignment to contain both of you as soon as @AkashWarlocks drops a comment here as well.

AkashWarlocks commented 1 year ago

Thanks @RafaelAPB. Will update!

petermetz commented 1 year ago

Thanks @RafaelAPB. Will update!

@AkashWarlocks Thanks for the comment, now I was able to assign the task to you as well!