We have the disk clean-up in the CI off by default because it takes a few
minutes to perform and most jobs don't need it, but for Corda it seems
necessary because our tests started failing with the message below
(lines wrapped to make sure we don't run over the 100 character limit
for the git commit message)
cactus-corda-4-8-all-in-one-flowdb:2024-07-08-hotfix-1]
[WARN] 09:48:28+0000 [Thread-2
(ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$6@11a43807)]
core.server. -
AMQ222210: Free storage space is at 145.7MB of 77.9GB total. Usage rate is 99.8% which is
beyond the configured . System will start blocking producers.
[x] Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
[x] Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
[x] Follow the Commit Linting specification. You may refer to this link for more information.
Character Limit
[x] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
[x] Commit Message per line must not exceed 80 characters (including spaces and special characters).
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.
We have the disk clean-up in the CI off by default because it takes a few minutes to perform and most jobs don't need it, but for Corda it seems necessary because our tests started failing with the message below (lines wrapped to make sure we don't run over the 100 character limit for the git commit message)
cactus-corda-4-8-all-in-one-flowdb:2024-07-08-hotfix-1] [WARN] 09:48:28+0000 [Thread-2 (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$6@11a43807)] core.server. - AMQ222210: Free storage space is at 145.7MB of 77.9GB total. Usage rate is 99.8% which is beyond the configured. System will start blocking producers.
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.