hyperledger-cacti / cacti

Hyperledger Cacti is a new approach to the blockchain interoperability problem
https://wiki.hyperledger.org/display/cactus
Apache License 2.0
344 stars 286 forks source link

refactor(ci/github): run weaver tests on schedule, re-use workflows #3437

Closed jenniferlianne closed 3 months ago

jenniferlianne commented 4 months ago

Primary change:

Creates a central workflow to run all 13 weaver test workflows from either a push, a pull request, a github command, or a schedule.

Passes a 'run_all' boolean to sub-workflows to specify if all tests should be run, not just those with changes.

Secondary changes:

Notes:

Depends on #3446

Pull Request Requirements

Character Limit

A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.

sandeepnRES commented 4 months ago

I've removed all weaver checks from required ones from branch protection rules (an exception for this PR as it is refactoring the CI itself), as it was blocking the PR to be merged. @jenniferlianne please investigate about ActionLint as @petermetz suggested, and once the PR is merged please ping me I'll add new CI checks as required in branch protection rules.

jenniferlianne commented 4 months ago

@petermetz I have updated the ActionLint version to the latest, but it still fails. The linter might be a getting stuck on a permissions issue between repos. (Settings->General->Actions Permissions). Mine is set to run all.

petermetz commented 4 months ago

@jenniferlianne Now I remember! We didn't have time to fix all the linter errors in certain yaml files at the introduction of the ActionLint job and there was no documented way to ignore them so the ActionLint job deletes a list of the yaml files that we wanted to ignore as a workaround. I've just pushed a potential fix, but let's see if it actually works.

petermetz commented 3 months ago

@jenniferlianne I've put the fix here: #3446 once that gets merged to main and this one rebased onto main then the ActionLint job will start passing on this PR as well.

github-actions[bot] commented 3 months ago

This PR/issue depends on: