While fabric setup for weaver tests downloads images specified in the Makefile, when the network is brought up the latest versions are pulled.
Primary Change:
pass fabric versions from Makefile to network.sh, ensuring they are used
Secondary Changes:
network.sh:
allow specifying fabric ca version
set exit on error bash flag to avoid continuing if script is in error
re-write unsupported version tests to not not generate error
Pull Request Requirements
[x] Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
[x] Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
[x] Follow the Commit Linting specification. You may refer to this link for more information.
Character Limit
[x] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
[x] Commit Message per line must not exceed 80 characters (including spaces and special characters).
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.
While fabric setup for weaver tests downloads images specified in the Makefile, when the network is brought up the latest versions are pulled.
Primary Change:
Secondary Changes:
network.sh:
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.