Closed ashnashahgrover closed 3 months ago
@ashnashahgrover the pr-commit parity checker is failing because your PR message contains a special character after Primary Changes
This is how it is getting rendered in my mail
I then updated your PR message and now when I run it, it still fails as there is diff (very minute)
I have updated it again and it still fails and now this is something which my upcoming patch for the CI test will fix. (Please do not spend any time on fixing the Commit Parity check)
LGTM, thank you!
Please run
yarn run lint
to format sources and fix the lint CI error
Done.
Commit to be reviewed
test(aries): refactor jest test negative test cases
Fixes #3473
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.