hyperledger-cacti / cacti

Hyperledger Cacti is a new approach to the blockchain interoperability problem
https://wiki.hyperledger.org/display/cactus
Apache License 2.0
344 stars 286 forks source link

test(aries): refactor jest test negative test cases #3474

Closed ashnashahgrover closed 3 months ago

ashnashahgrover commented 3 months ago

Commit to be reviewed

test(aries): refactor jest test negative test cases

Primary Changes
----------------
1. Refactored all the negative test case exception assertions for
cactus-plugin-ledger-connector-aries. Removed try-catch blocks,
replaced with declarations through jest-extended's own API.

Fixes #3473

Pull Request Requirements

Character Limit

A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.

jagpreetsinghsasan commented 3 months ago

@ashnashahgrover the pr-commit parity checker is failing because your PR message contains a special character after Primary Changes This is how it is getting rendered in my mail image

I then updated your PR message and now when I run it, it still fails as there is diff (very minute) image

I have updated it again and it still fails and now this is something which my upcoming patch for the CI test will fix. (Please do not spend any time on fixing the Commit Parity check)

ashnashahgrover commented 3 months ago

LGTM, thank you!

Please run yarn run lint to format sources and fix the lint CI error

Done.