Closed sandeepnRES closed 3 months ago
@petermetz I think the Corda connector and any examples in the non-Weaver parts of Cacti ought to be similarly upgraded (assuming they have not already been done). This change will allow us to finally escape Java 8 and also avoid periodic vulnerability reports.
@petermetz I think the Corda connector and any examples in the non-Weaver parts of Cacti ought to be similarly upgraded (assuming they have not already been done). This change will allow us to finally escape Java 8 and also avoid periodic vulnerability reports.
@VRamakrishna I couldn't agree more and I was going to propose the exact same thing for the same reasons myself, I'm glad we are thinking alike about this! :-) I'll send in a pull request soon as well with the cactus corda connector being bumped up to JDK 17, Spring Boot 3 and Gradle 8 and Corda 4.12 as well. I'm very happy about this!
Hi @petermetz Resolved the conflict. Please review.
Hi @petermetz there's some docs updates I've also added, those are small changes that Rama and me didn't want to open new PR for, but still is orthogonal to this PR, so that's why I've kept the commit separate.
feat(weaver): upgrade to corda 4.12 and jvm 17
chore: updating golang version in docs, and proto-grpc dependencies
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.