test: refactor jest test negative test cases - phase 1

hyperledger-cacti / cacti

Hyperledger Cacti is a new approach to the blockchain interoperability problem

https://wiki.hyperledger.org/display/cactus

Apache License 2.0

344 stars 286 forks source link

test: refactor jest test negative test cases - phase 1 #3488

Closed ashnashahgrover closed 1 month ago

ashnashahgrover commented 3 months ago

Commit to be reviewed

test: refactor jest test negative test cases - phase 1

Primary Changes
---------------
1. Refactored all remaining negative test case exception assertions under cacti/packages Removed try-catch blocks, replaced with declarations through jest-extended's own API.

Fixes #3483

ashnashahgrover commented 3 months ago

@jagpreetsinghsasan

Should I make a issue to investigate the inconsistencies in deploy-contract-from-json-xdai.test.ts and make this issue dependent on that?

petermetz commented 1 month ago

Closing this due to inactivity, please feel free to re-open anytime if/when bandwidth is available to take it to the finish line (some of the checks are failing such as the linter)