hyperledger-cacti / cacti

Hyperledger Cacti is a new approach to the blockchain interoperability problem
https://wiki.hyperledger.org/display/cactus
Apache License 2.0
344 stars 286 forks source link

test(ethereum): fix broken validations in tests #3496

Closed ashnashahgrover closed 1 month ago

ashnashahgrover commented 2 months ago

Commit to be reviewed

test(ethereum): fix broken validations in tests

Primary Changes
---------------
1. Added code to deployContract in plugin-ledger-connector-ethereum.ts that checks if any
unexpected arguments are present, and if so throws an error.
2. Modified test on line 169 in geth-invoke-web3-method-v1.test.ts so that required argument for
invokeRawWeb3EthMethod is missing as required by the test description.

Fixes #3487

Pull Request Requirements

Character Limit

A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.

petermetz commented 1 month ago

Closing this due to inactivity, please feel free to re-open anytime if/when bandwidth is available to take it to the finish line.