hyperledger-cacti / cacti

Hyperledger Cacti is a new approach to the blockchain interoperability problem
https://wiki.hyperledger.org/display/cactus
Apache License 2.0
344 stars 286 forks source link

test(connector-besu): jest migrate get-past-logs-endpoint.test.ts #3529

Closed petermetz closed 2 months ago

petermetz commented 2 months ago

Depends on #3528 => test(test-tooling): add new besu AIO image builder utility

Fixes #3527

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

Pull Request Requirements

Character Limit

A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.

petermetz commented 2 months ago

LGTM @petermetz the parity check is failing as I am removing the Fixes/Depends lines before comparing the string as the string resolution of issue numbers #abcd in PR description is often done as hyperledger#abcd thus making the comparision harder. Shall I push a fix (along with other gh issues around pr commit parity) to include these lines to be checked as well ?

@jagpreetsinghsasan Got it, thanks! Yes, I would fix it by making sure to remove the fixes/depends lines from either both or none of them (commit message + pr description).

dpulls[bot] commented 2 months ago

:tada: All dependencies have been resolved !

github-actions[bot] commented 2 months ago

This PR/issue depends on: