Closed petermetz closed 2 months ago
LGTM @petermetz the parity check is failing as I am removing the
Fixes/Depends
lines before comparing the string as the string resolution of issue numbers#abcd
in PR description is often done ashyperledger#abcd
thus making the comparision harder. Shall I push a fix (along with other gh issues around pr commit parity) to include these lines to be checked as well ?
@jagpreetsinghsasan Got it, thanks! Yes, I would fix it by making sure to remove the fixes/depends lines from either both or none of them (commit message + pr description).
:tada: All dependencies have been resolved !
This PR/issue depends on:
Depends on #3528 => test(test-tooling): add new besu AIO image builder utility
Fixes #3527
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.