hyperledger-cacti / cacti

Hyperledger Cacti is a new approach to the blockchain interoperability problem
https://wiki.hyperledger.org/display/cactus
Apache License 2.0
344 stars 286 forks source link

refactor(cbdc-example): added gateways and contracts #3534

Closed LordKubaya closed 2 months ago

LordKubaya commented 2 months ago
gitguardian[bot] commented 2 months ago

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [10502732](https://dashboard.gitguardian.com/workspace/236628/incidents/10502732) | Triggered | Generic High Entropy Secret | b0d5dbb85ecd672a1d2f4c726fa0236f14223f88 | examples/cactus-example-cbdc-bridging-backend/src/crypto-material/crypto-material.json | [View secret](https://github.com/hyperledger/cacti/commit/b0d5dbb85ecd672a1d2f4c726fa0236f14223f88#diff-b22ca85dae061ef31156e40aebb82f99fffaf1dadb57a691ae9a7b23f94bb21cL28) | | [10502733](https://dashboard.gitguardian.com/workspace/236628/incidents/10502733) | Triggered | Generic High Entropy Secret | b0d5dbb85ecd672a1d2f4c726fa0236f14223f88 | examples/cactus-example-cbdc-bridging-backend/src/crypto-material/crypto-material.json | [View secret](https://github.com/hyperledger/cacti/commit/b0d5dbb85ecd672a1d2f4c726fa0236f14223f88#diff-b22ca85dae061ef31156e40aebb82f99fffaf1dadb57a691ae9a7b23f94bb21cL24) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

RafaelAPB commented 2 months ago

Merged as feedback was incorporated