hyperledger-cacti / cacti

Hyperledger Cacti is a new approach to the blockchain interoperability problem
https://wiki.hyperledger.org/display/cactus
Apache License 2.0
344 stars 286 forks source link

ci(github): add check to validate exported types being correct #3561

Closed ruzell22 closed 1 week ago

ruzell22 commented 1 month ago

Commit to be reviewed


ci(github): add check to validate exported types being correct

Primary Changes
---------------
1. Added get-all-tgz-path.ts to get all tgz files path
2. Added run-attw-on-tgz.ts to run attw on each tgz filepath
3. Added are-the-types-wrong as part of the custom-checks mechanism

Fixes: #3140

Pull Request Requirements

Character Limit

A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.

petermetz commented 1 week ago

@ruzell22 Are you still working on this?

ruzell22 commented 1 week ago

@petermetz yes, I am. I currently have the codes ready to be push with the added extra step to wipe all the existing .tgz files first and also the additional information on the .tgz files with error after running attw. However, I just noticed something when testing before pushing the code wherein on the previous test without the wiping, it patches and detects 71 tgz files. After I put the wipe before patching and detecting tgz files, it can only detect 46 file paths.

petermetz commented 1 week ago

@petermetz yes, I am. I currently have the codes ready to be push with the added extra step to wipe all the existing .tgz files first and also the additional information on the .tgz files with error after running attw. However, I just noticed something when testing before pushing the code wherein on the previous test without the wiping, it patches and detects 71 tgz files. After I put the wipe before patching and detecting tgz files, it can only detect 46 file paths.

@ruzell22 Got it, thank you for the update! Take your time, I just wanted to make sure that the PR is not being held up by something.

ruzell22 commented 1 week ago

@petermetz on the latest push, there are no undefined output now. Also, I have created a new issue #3623 that relates to issue #3140 for fixing the packages that are failing with ATTW check in custom-checks.