Closed sirisayshello closed 1 month ago
@sirisayshello thankyou for your contribution to Hyperledger Cacti. I have some review comments on this one
I want to work on this
, so that we can assign you the task. This helps us in avoiding duplications of the efforts spent on its completion.commit message
with what you wrote as the pr description as well? (All you have to do is amend the commit message with the exact copy paste of your pr description, without the Pull Request Requirements....
paragraph). This helps us with descriptive commit messages and a parity with the PR associated with them.@jagpreetsinghsasan certainly, I will make the requested changes!
@jagpreetsinghsasan I have now updated the commit to include the PR description.
@outSH Sorry, my bad; I missed that one. I have now made the requested changes!
LGTM (Not approving this intentionally as Peter has already checked and approved, thus dismissing my review)
Closing and re-opening in hopes of triggering the dpull bot
Fixes #3550
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.