hyperledger-cacti / cacti

Hyperledger Cacti is a new approach to the blockchain interoperability problem
https://wiki.hyperledger.org/display/cactus
Apache License 2.0
344 stars 286 forks source link

docs(ledger-browser): add links to documentation #3575

Closed sirisayshello closed 1 month ago

sirisayshello commented 1 month ago
Changes
----------------
1. Added links to documentation and setup guides for eth-browser and fabric-browser.

Fixes #3550

Pull Request Requirements

Character Limit

A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.

jagpreetsinghsasan commented 1 month ago

@sirisayshello thankyou for your contribution to Hyperledger Cacti. I have some review comments on this one

  1. Can you please comment on the task #3550 with something like I want to work on this, so that we can assign you the task. This helps us in avoiding duplications of the efforts spent on its completion.
  2. Can you update the commit message with what you wrote as the pr description as well? (All you have to do is amend the commit message with the exact copy paste of your pr description, without the Pull Request Requirements.... paragraph). This helps us with descriptive commit messages and a parity with the PR associated with them.
sirisayshello commented 1 month ago

@jagpreetsinghsasan certainly, I will make the requested changes!

sirisayshello commented 1 month ago

@jagpreetsinghsasan I have now updated the commit to include the PR description.

sirisayshello commented 1 month ago

@outSH Sorry, my bad; I missed that one. I have now made the requested changes!

jagpreetsinghsasan commented 1 month ago

LGTM (Not approving this intentionally as Peter has already checked and approved, thus dismissing my review)

petermetz commented 1 month ago

Closing and re-opening in hopes of triggering the dpull bot