Closed aldousalvarez closed 1 month ago
PR-Commit Parity is failing to a known bug: https://github.com/hyperledger-cacti/cacti/issues/3557 (This workflow result can be skipped for evaluating PR for merge)
@outSH re-requested for review, already done with your requested changes. Thank you
@petermetz re-requested for review, already fixed the requested changes. The besu test packages are now passing. Thank you
@petermetz I have fixed the problem where the ctp-ledger-connector-besu is being skipped, and it is now passing. Re-requested for review. Thank you.
Commit to be reviewed
test(test-plugin-ledger-connector-besu): jestify v21-sign-transaction-endpoint
Fixes #3565
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.