hyperledger-cacti / cacti

Hyperledger Cacti is a new approach to the blockchain interoperability problem
https://wiki.hyperledger.org/display/cactus
Apache License 2.0
344 stars 286 forks source link

test(test-plugin-ledger-connector-besu): jestify v21-sign-transaction-endpoint #3576

Closed aldousalvarez closed 1 month ago

aldousalvarez commented 1 month ago

Commit to be reviewed

test(test-plugin-ledger-connector-besu): jestify v21-sign-transaction-endpoint

Primary Changes
----------------
packages/cactus-test-plugin-ledger-connector-besu/src/test/typescript/
integration/plugin-validator-besu/v21-sign-transaction-endpoint.test.ts

Fixes #3565

Pull Request Requirements

Character Limit

A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.

jagpreetsinghsasan commented 1 month ago

PR-Commit Parity is failing to a known bug: https://github.com/hyperledger-cacti/cacti/issues/3557 (This workflow result can be skipped for evaluating PR for merge)

aldousalvarez commented 1 month ago

@outSH re-requested for review, already done with your requested changes. Thank you

aldousalvarez commented 1 month ago

@petermetz re-requested for review, already fixed the requested changes. The besu test packages are now passing. Thank you

aldousalvarez commented 1 month ago

@petermetz I have fixed the problem where the ctp-ledger-connector-besu is being skipped, and it is now passing. Re-requested for review. Thank you.