hyperledger-cacti / cacti

Hyperledger Cacti is a new approach to the blockchain interoperability problem
https://wiki.hyperledger.org/display/cactus
Apache License 2.0
344 stars 286 forks source link

ci(github): potential CODEOWNERS syntax fix - one line per maintainer #3581

Closed petermetz closed 1 month ago

petermetz commented 1 month ago

We've been having sytnax issues with the CODEOWNERS file for years where GitHub is claiming that the usernames of certain maintainers don't exist even though they defintely do.

This is an attempt to get that error unstuck by adding each wildcard entry as its own line in the text file. Will be interesting to see if this makes to false-positive syntax errors go away.

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

Pull Request Requirements

Character Limit

A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.

outSH commented 1 month ago

I think the failing maintainers are not part of this org (https://github.com/orgs/hyperledger-cacti/people?query=) and not in maintainers team (https://github.com/orgs/hyperledger-cacti/teams/cacti-maintainers), that may be the main issue

ryjones commented 1 month ago

I think the failing maintainers are not part of this org (https://github.com/orgs/hyperledger-cacti/people?query=) and not in maintainers team (https://github.com/orgs/hyperledger-cacti/teams/cacti-maintainers), that may be the main issue

correct

petermetz commented 1 month ago

@ryjones @outSH @jagpreetsinghsasan Oh, OK, then this can be closed, thank you! :-)