hyperledger-cacti / cacti

Hyperledger Cacti is a new approach to the blockchain interoperability problem
https://wiki.hyperledger.org/display/cactus
Apache License 2.0
344 stars 286 forks source link

fix(besu): deployContractSolBytecodeNoKeychainV1 requires keychainId #3587

Closed petermetz closed 1 month ago

petermetz commented 1 month ago

In the DeployContractSolidityBytecodeNoKeychainV1Request of packages/cactus-plugin-ledger-connector-besu/src/main/json/openapi.tpl.json there are parameters that are required despite the entire point of this operation is to not need them (e.g. keychainId and contract JSON object).

Fixes #3586

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

Pull Request Requirements

Character Limit

A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.

petermetz commented 1 month ago

I investigated why the DAST scan is failing but could not reproduce the problem locally. I'm going to assume that it's an issue with the environment setup logic of the CI job and not an issue with the endpoints. Based on that I'll disable the DAST scan for now until we can figure out what's wrong with it.

Tracking the fix here: https://github.com/hyperledger-cacti/cacti/issues/3596