hyperledger-cacti / cacti

Hyperledger Cacti is a new approach to the blockchain interoperability problem
https://wiki.hyperledger.org/display/cactus
Apache License 2.0
344 stars 286 forks source link

chore: install secret detection on pre-commit hooks #3606

Open zondervancalvez opened 3 weeks ago

zondervancalvez commented 3 weeks ago

Commit to be reviewed

chore: install secret detection on pre-commit hooks

Primary Changes
----------------
1. Installed gitleaks for secret detection.
2. This pre-commit checker detects any secrets
or crypto so that it doesn't get pushed to
the github repo.
3. Added script to run install and uninstall
the pre-commit hooks in package.json

Fixes #2290

Pull Request Requirements

Character Limit

A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.

zondervancalvez commented 3 weeks ago

image

petermetz commented 1 week ago

@zondervancalvez Are you still working on this?

zondervancalvez commented 1 week ago

@zondervancalvez Are you still working on this?

@petermetz Yes. I just prioritized the #3614