test(test-plugin-ledger-connector-besu): jestify get-block-endpoint

krriscode commented 3 weeks ago

Primary Changes:

packages/cactus-test-plugin-ledger-connector-besu/src/test/typescript/
integration/plugin-validator-besu/get-block-endpoint.test.ts

Fixes: https://github.com/hyperledger-cacti/cacti/issues/3500

Signed-off-by: krriscode 85664362+krriscode@users.noreply.github.com

Migration of get-block-endpoint.ts from tape-promise to Jest. Update tests for improved reliability and performance.

Pull Request Requirements

[ ] Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
[ ] Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
[ ] Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

[ ] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
[ ] Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.

krriscode commented 2 weeks ago

Hi @petermetz, I have fixed the commit message as you suggested please review the PR.

krriscode commented 1 week ago

Hi @petermetz, I have check git config twice and it is correct, below is screenshot of it I got stuck here, could you please help me to resolve this issue.

petermetz commented 2 days ago

@krriscode That's strange, let me take a look at it myself then. FYI: I'll probably end up rebasing your branch manually, so if you see divergence between your local branch and the remote branch that's no cause for alarm.

petermetz commented 2 days ago

@krriscode Upon further investigation it looks like you did manage to fix it after all, so we are good to go now we just need other maintainers to review it and then it can be merged. Thank you again for the contribution!

hyperledger-cacti / cacti

test(test-plugin-ledger-connector-besu): jestify get-block-endpoint #3607