hyperledger-cacti / cacti

Hyperledger Cacti is a new approach to the blockchain interoperability problem
https://wiki.hyperledger.org/display/cactus
Apache License 2.0
344 stars 286 forks source link

test(connector-besu): migrate get-past-logs-endpoint to Jest #3608

Open Akshitha1020 opened 3 weeks ago

Akshitha1020 commented 3 weeks ago

Commit to be reviewed

test(connector-besu): migrate get-past-logs-endpoint to Jest

 Primary Changes
 ------------------
 1. Updated the migrate get-past-logs-endpoint test 
     to use Jest
 2. Updated the ci.yaml TAPE_TEST_PATTERN to
     incorporate the same

Fixes #3505

Pull Request Requirements

Character Limit

A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.

Akshitha1020 commented 2 weeks ago

Hi @petermetz, tried running yarn lint locally, but no issues are found, please find the screenshot attached. Could you please help me resolve this.

image
jagpreetsinghsasan commented 2 weeks ago

@Akshitha1020 after running yarn lint you will see some files modified. You have to commit those changes (Please make sure to squash merge all the commits into one single commit before pushing).

In this PR, the lint failed here packages/cactus-test-plugin-ledger-connector-besu/src/test/typescript/integration/plugin-validator-besu/get-past-logs-endpoint.test.ts line 92 (You need to add a space after IPluginLedgerConnectorBesuOptions and before =

jagpreetsinghsasan commented 2 weeks ago

Also, to fix the PR - Commit Parity failing check, please update your commit message to this (I have updated the PR Desciption accordingly)

test(connector-besu): migrate get-past-logs-endpoint to Jest 

     Primary Changes
     ------------------
     1. Updated the migrate get-past-logs-endpoint test 
         to use Jest
     2. Updated the ci.yaml TAPE_TEST_PATTERN to
         incorporate the same

Fixes #3505
Akshitha1020 commented 2 weeks ago

Hi @jagpreetsinghsasan, I have done the changes as you mentioned, please re-review and let me know.

jagpreetsinghsasan commented 2 weeks ago

@Akshitha1020 all good from my past review comment. There is a merge conflict, can you please resolve that as well? image

petermetz commented 1 week ago

@Akshitha1020 If you are end up struggling with the git operations needed to resolve the merge conflicts just let me know and I can help (You'll just need to invite me as a collaborator to your fork so that I have permission to push to your PR branch directly)

Akshitha1020 commented 1 week ago

Hi @petermetz, resolved the conflicts but on squashing the commits again it is showing conflicts. I have invited you to be a collaborator to my fork, please accept.

petermetz commented 1 week ago

Hi @petermetz, resolved the conflicts but on squashing the commits again it is showing conflicts. I have invited you to be a collaborator to my fork, please accept.

@Akshitha1020 Okay, no worries! I accepted the invite just now, I'll push the changes soon.