hyperledger-cacti / cacti

Hyperledger Cacti is a new approach to the blockchain interoperability problem
https://wiki.hyperledger.org/display/cactus
Apache License 2.0
344 stars 286 forks source link

ci(check-ci-skip): fix commitMessagesMetadata.forEach is not a function #3618

Open zondervancalvez opened 2 weeks ago

zondervancalvez commented 2 weeks ago

Commit to be reviewed

ci(check-ci-skip): fix commitMessagesMetadata.forEach is not a function

Primary Changes
----------------
1. Changed the method in getting the commit
message from GitHub API to shell command to avoid
the rate limits in calling the API.
2. Same goes for the author of commit message,
we use shell command to fetch the username.

Fixes #3614

Pull Request Requirements

Character Limit

A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.

zondervancalvez commented 1 week ago

@zondervancalvez Could you please address the questions above? Hi @petermetz please see the latest commit. Thanks

petermetz commented 1 day ago

@zondervancalvez Could you please address the questions above? Hi @petermetz please see the latest commit. Thanks

@zondervancalvez I'm sorry, I can't find the answer to my question from earlier regarding the crashes. Could you please be more specific about which part of the commit message is answering that question?