search

hyperledger-cacti / cacti

Hyperledger Cacti is a new approach to the blockchain interoperability problem
https://wiki.hyperledger.org/display/cactus
Apache License 2.0
344 stars 286 forks source link

ci(github): fix type exports in packages/cactus-plugin-ledger-connector-polkadot #3634

Open ruzell22 opened 1 week ago

ruzell22 commented 1 week ago

Description

Relates to: #3140

Ignore pattern has been added in tools/custom-checks/get-all-tgz-path.ts in PR #3561 for packages that are having error when running the newly added check in custom-checks to validate exported types being correct so that the job will pass for now.

This ticket is created to fix packages/cactus-plugin-ledger-connector-polkadot/hyperledger-cactus-plugin-ledger-connector-polkadot-*.tgz and delete it in the ignore pattern right after. For more info about the custom-check log, refer to this github action link: https://github.com/hyperledger-cacti/cacti/actions/runs/11798447068/job/32864671597?pr=3561

and this discussion reply: https://github.com/hyperledger-cacti/cacti/pull/3561#pullrequestreview-2430386262

Related link that can help with regards to the error logs: https://www.npmjs.com/package/@arethetypeswrong/cli

Acceptance Criteria

  1. ci yarn-custom-checks should pass
  2. remove the ignore pattern for this specific package in tools/custom-checks/get-all-tgz-path.ts
petermetz commented 1 week ago

@ruzell22 Instead of fix tgz file I'd say fix type exports. There is nothing wrong with the tgz file itself, the problem is type exports of the package. (Same advice for all the other issues with the same topic)