search

hyperledger-cacti / cacti

Hyperledger Cacti is a new approach to the blockchain interoperability problem
https://wiki.hyperledger.org/display/cactus
Apache License 2.0
344 stars 286 forks source link

ci(github): fix type exports in packages/cactus-common #3635

Open ruzell22 opened 1 week ago

ruzell22 commented 1 week ago

Description

Relates to: #3140

Ignore pattern has been added in tools/custom-checks/get-all-tgz-path.ts in PR #3561 for packages that are having error when running the newly added check in custom-checks to validate exported types being correct so that the job will pass for now.

This ticket is created to fix packages/cactus-common/hyperledger-cactus-common-*.tgz and delete it in the ignore pattern right after. For more info about the custom-check log, refer to this github action link: https://github.com/hyperledger-cacti/cacti/actions/runs/11798447068/job/32864671597?pr=3561

and this discussion reply: https://github.com/hyperledger-cacti/cacti/pull/3561#pullrequestreview-2430386262

Related link that can help with regards to the error logs: https://www.npmjs.com/package/@arethetypeswrong/cli

Acceptance Criteria

  1. ci yarn-custom-checks should pass
  2. remove the ignore pattern for this specific package in tools/custom-checks/get-all-tgz-path.ts