hyperledger-cacti / cacti

Hyperledger Cacti is a new approach to the blockchain interoperability problem
https://wiki.hyperledger.org/display/cactus
Apache License 2.0
344 stars 286 forks source link

ci(github): fix type exports in packages/cactus-common #3649

Open ruzell22 opened 14 hours ago

ruzell22 commented 14 hours ago

Commit to be reviewed


ci(github): fix type exports in packages/cactus-common

Primary Changes
---------------
1. Remove packages/cactus-common/hyperledger-cactus-common-*.tgz in ignore
paths in get-all-tgz-path.ts file
2. Added the missing LogLevelDesc in index.ts as per attw -f json error log

Fixes: #3635

Pull Request Requirements

Character Limit

A Must Read for Beginners For rebasing and squashing, here's a must read guide for beginners.

ruzell22 commented 14 hours ago

Before fix: image adding -f json to attw command, it shows which file and which problem with export it is having.

After fix: image yarn run custom-checks and attw with and without -f json flag are all passing

EDIT:

I made changes to index.js and index.d.ts, however, it is not being added by git add -A before committing and pushing the code.