search

hyperledger-cacti / cacti

Hyperledger Cacti is a new approach to the blockchain interoperability problem
https://wiki.hyperledger.org/display/cactus
Apache License 2.0
344 stars 286 forks source link

feat(connector-quorum): support Quorum v21.x #901

Closed petermetz closed 3 years ago

petermetz commented 3 years ago

Description

Depends on #900

The connector should support Quorum v21.4.1. We need actual test coverage and the AIO image updated for said test coverage so that we can credibly claim said support instead of just saying "well it should because I read the release notes of Quorum v21.4.1 for example and nothing struck me as a change that would mess with our connector's ability to work with it".

The new image tag could be hyperledger/cactus-quorum-v21.4.1-all-in-one-2021-05-03-$SHA[1-7]

https://docs.goquorum.consensys.net/en/stable/HowTo/GetStarted/Wizard/Interacting/

Acceptance Criteria

Specific test case that is locked down to a v21.4.1 ledger (the AIO image) so that even if we add more things later on, this test remains frozen in time forever verifying the connector against v21.4.1. This will be extremely valuable in the long run in catching regressions. Will probably have to make sure an updated version of the Quorum AIO image is published because right now it can only do Quorum 2.3.0 with Tessera 0.10.0 IIRC

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo @petermetz @arnab-roy

github-actions[bot] commented 3 years ago

:hourglass_flowing_sand: Alright! Looks like we need to wait for some dependencies:

:bulb: Don't worry, I will continue watching the list above and keep this comment updated. To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!