Closed lebdron closed 5 years ago
CI confuses me a bit - looks like all tests are passed but it shows failure status.
also it would be nice to give the patch patch/synchronize-lock-recursion-thread-safety.patch
a more meaningful and descriptive name. I would suggest either renaming it with some rxcpp
prefix or moving to a directory like patches/external/rxcpp
(it other patches to rxcpp are probable).
Description of the Change
Create a
synchronize
subject in consensus to queue the events from the network without locking the operation of consensuscurrent_thread
scheduler withsynchronize
publish().ref_count()
to YacGateImpl observable to eliminate redundant calls toflat_map
if multiple subscribers are presentgetSpdlogLogLevel
consensus_sunny_day
test 🎉blocking_observable
in TestSubscriberBenefits
Consensus can process messages from the network while the pipeline is running
Possible Drawbacks
A separate thread is allocated to the pipeline