hyperledger-iroha / iroha-dco

Iroha - A simple, decentralized ledger
http://iroha.tech
Apache License 2.0
988 stars 296 forks source link

Event loop for pipeline processing #2209

Closed lebdron closed 5 years ago

lebdron commented 5 years ago

Description of the Change

Create a synchronize subject in consensus to queue the events from the network without locking the operation of consensus

Benefits

Consensus can process messages from the network while the pipeline is running

Possible Drawbacks

A separate thread is allocated to the pipeline

luckychess commented 5 years ago

CI confuses me a bit - looks like all tests are passed but it shows failure status.

MBoldyrev commented 5 years ago

also it would be nice to give the patch patch/synchronize-lock-recursion-thread-safety.patch a more meaningful and descriptive name. I would suggest either renaming it with some rxcpp prefix or moving to a directory like patches/external/rxcpp (it other patches to rxcpp are probable).