New library implementation

hyperledger-iroha / iroha-ios

iOS Swift library for Iroha, a simple distributed ledger

https://wiki.hyperledger.org/display/iroha

Other

92 stars 59 forks source link

New library implementation #75

Closed ERussel closed 5 years ago

ERussel commented 5 years ago

Full Iroha API support implementation add
Cocoapods support add

neewy commented 5 years ago

AFAIK we need to put license header to all code files. What is a code file and where to find this rule — might be the questions you'll ask but I can't find them now. Maybe somewhere in wiki.hyperledger.org.

As for now — you can try using grep as Mikhail did here: https://github.com/hyperledger/iroha/pull/1944

neewy commented 5 years ago

https://wiki.hyperledger.org/community/copyright-and-license-policy?s[]=license

neewy commented 5 years ago

https://www.hyperledger.org/about/charter #13

neewy commented 5 years ago

@ERussel any updates?

ERussel commented 5 years ago

@neewy, license headers added to all implemented source code, except those generated by protobuf utility. How do think should we also add license header to them?

neewy commented 5 years ago

@ERussel generated code should not be stored in repo usually. We don't need to put there license headers anyway.

ERussel commented 5 years ago

@ERussel generated code should not be stored in repo usually. We don't need to put there license headers anyway.

I decided that it will be simpler for library user. In this case he/she needs only XCode and just adds library as a dependency to a project. Otherwise we need to require also additional cli tools to be installed.