hyperledger-iroha / iroha

Iroha - A simple, enterprise-grade decentralized ledger
https://wiki.hyperledger.org/display/iroha
Apache License 2.0
438 stars 280 forks source link

fix: Improve queue transactions handling #4947

Closed dima74 closed 2 months ago

dima74 commented 2 months ago

Description

Currently in some cases tps numbers (transactions per second) may be very unstable for network of a single peer. See https://github.com/hyperledger/iroha/issues/4727#issuecomment-2268694679 and https://github.com/hyperledger/iroha/issues/4727#issuecomment-2269086095 for detailed description of the reasons. This PR adjusts how transactions are handled in the queue, so tps will be more stable. Note that average tps should not change (maybe slightly improvement).

Here is comparison of tps:

Before After
1600_main 1600_fixed

Linked issue

Related: #4727

Benefits

Improve stability of the tps in case when there are a lot of requests and transaction queue is full

Checklist

github-actions[bot] commented 2 months ago

@BAStos525

mversic commented 2 months ago

failing tests