hyperledger-iroha / iroha

Iroha - A simple, enterprise-grade decentralized ledger
https://wiki.hyperledger.org/display/iroha
Apache License 2.0
438 stars 280 forks source link

feat(client_cli): Integrating CLI API to set and retrieve parameters. #4961

Open divyaranjan1905 opened 2 months ago

divyaranjan1905 commented 2 months ago

Description

This PR would integrate the necessary patchwork needed to ensure that one could use the client_cli of iroha to perform operations to set new values for parameters and retrieve existing ones.

Linked issue

Closes #4820

Benefits

This creates an easier way for the user to modify parameter values.

Checklist

github-actions[bot] commented 2 months ago

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification, and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Initial commit for parameters cli module.

Signed-off-by: Divya Ranjan <divya@subvertising.org>". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit
divyaranjan1905 commented 2 months ago

Okay, so @nxsaken and others. This draft PR might have several errors and the code might not be the best, bear with me as I fix these things.

mversic commented 1 month ago

@nxsaken what's the state with this?

nxsaken commented 1 month ago

@divyaranjan1905 hi, do you plan to finish this PR?

divyaranjan1905 commented 1 month ago

I do, I've simply been on a hiatus due to some stuff. I plan to get back on this within a week or so.