Closed SamHSmith closed 1 month ago
Currently the github runners are too slow for all the integration tests to pass.
Is increased timeouts necessary for a fix?
Is increased timeouts necessary for a fix?
Yes. Not locally, but in the CI it is necessary.
Note that #4996 switches to a faster runner, and adds retries for extra_functional
tests
Note that #4996 switches to a faster runner, and adds retries for
extra_functional
tests
The faster runner would be a good addition. But I think retries is a very bad idea.
Solution
The bug was that the node selection for the client was random. This meant that the node the client was using to observe the tests were being frozen. I fixed it so that the client always is connected to the genesis peer which never gets frozen.