search

hyperledger-iroha / iroha

Iroha - A simple, enterprise-grade decentralized ledger
https://wiki.hyperledger.org/display/iroha
Apache License 2.0
438 stars 280 forks source link

fix: Fix bug in test harness for unstable network #4980

Closed SamHSmith closed 1 month ago

SamHSmith commented 2 months ago

Solution

The bug was that the node selection for the client was random. This meant that the node the client was using to observe the tests were being frozen. I fixed it so that the client always is connected to the genesis peer which never gets frozen.

SamHSmith commented 2 months ago

Currently the github runners are too slow for all the integration tests to pass.

Erigara commented 2 months ago

Is increased timeouts necessary for a fix?

SamHSmith commented 2 months ago

Is increased timeouts necessary for a fix?

Yes. Not locally, but in the CI it is necessary.

nxsaken commented 1 month ago

Note that #4996 switches to a faster runner, and adds retries for extra_functional tests

SamHSmith commented 1 month ago

Note that #4996 switches to a faster runner, and adds retries for extra_functional tests

The faster runner would be a good addition. But I think retries is a very bad idea.