hyperledger-iroha / iroha

Iroha - A simple, enterprise-grade decentralized ledger
https://wiki.hyperledger.org/display/iroha
Apache License 2.0
438 stars 280 forks source link

[feature request] Return block hashes from `FindBlockHeaders` query #4982

Closed 0x009922 closed 2 months ago

0x009922 commented 2 months ago

Use case

In Explorer, we need to display blocks basic data, without its transactions. We display transactions separately, with pagination, lazily.

Problem

Desired solution

Implement FindBlockHeaders in a similar way to how FindTransactions works: it does not return a list of plain CommittedTransaction, but a list of TransactionQueryOutput - a wrap around CommittedTransaction with additional block_hash field.

mversic commented 2 months ago

FindBlockHeaders returns data without block hashes

a block hash is the hash of it's header, i.e. you can calculate it on the client side. I would close this issue

0x009922 commented 2 months ago

Understood, than it is fine!