hyperledger-iroha / iroha

Iroha - A simple, enterprise-grade decentralized ledger
https://wiki.hyperledger.org/display/iroha
Apache License 2.0
438 stars 280 forks source link

Rename `JsonString` to `JsonValue` #5003

Open mversic opened 2 months ago

mversic commented 2 months ago

although it's serialized as a string when serializing to SCALE, it's an implementation detail how json is stored in memory.

mversic commented 1 month ago

JsonValue is still revealing that it's in fact json that is used. It feels as if we're leaking an implementation detail here. Maybe we should name it just Value instead? This would allow us to use a different format if we decide to do so