Open dima74 opened 1 month ago
From SDK standpoint, it can be useful to clearly see the separation between durations and timestamps in the schema. Currently they are just *_ms: u64
fields.
From SDK standpoint, it can be useful to clearly see the separation between durations and timestamps in the schema. Currently they are just
*_ms: u64
fields.
One option I see here is to create DurationMs
and TimestampMs
newtype wrappers for u64
and use them correspondingly
One option I see here is to create
DurationMs
andTimestampMs
newtype wrappers foru64
and use them correspondingly
That would be helpful.
Context
Fixes #4729
Solution
Use
std::time::SystemTime
for time stamps instead ofstd::time::Duration
.SystemTime
requiresstd
, so it will not be available inside WASM.chrono::DateTime
might be used, but it will be more complex (in particular we will have to handle leap seconds), so I am not sure that it is worth itMigration Guide (optional)
Review notes (optional)
Checklist
CONTRIBUTING.md
.