Open s8sato opened 1 month ago
@BAStos525
Genesis needs to be updated
Updates:
genesis.json
includes not wasm blobs but hashesNotes:
scripts/tests/multisig.*
) are failing after rebase for some reasonUpdates:
genesis.json
a special field to register wasm triggersgenesis.json
includes not wasm blobs but hashesNotes:
Currently script tests (
scripts/tests/multisig.*
) are failing after rebase for some reason
This was because only integration tests passed due to my overlook of privileged Alice in TestGenesis
. Fixed
integration::extra_functional::restart_peer::restarted_peer_should_have_the_same_asset_amount
Major updates:
transaction_ttl
as humantime::Duration
and convert to millisecondskagami::genesis::generate
wasm_samples
, remove multisig_*/build.rs
iroha_multisig_data_model
crateMinor updates are fixed up with existing commits.
Notes:
genesis_block_builder_example
is failing to compile for some reason. Left to another PRI'd address further feedbacks in another PR of #4930. This PR is already enough hard to maintain
Updates:
genesis.json
directorykagami::genesis::generate
genesis.json
a special field to register wasm triggersNotes:
Does this have something to do with the repository change?
When an outside contributor submits a pull request to a public repository, a maintainer with write access may need to approve some workflow runs.
EDIT: resolved by joining the organization
BREAKING CHANGES:
CanRegisterAnyTrigger
CanUnregisterAnyTrigger
permissions for internal operations onlyGenesisWasmTrigger
underRawGenesisTransaction
forgenesis.json
readabilityMultisig*Args
attached to multi-signature operationsdefaults/genesis.json
assumeswasm_triggers[*].action.executable
is prebuilt underwasm/target/prebuilt/libs/
Major commits:
Context
Opens:
5022: essential to security
5185: essential to true utility
5160
5178
Solution
Each commit is explained below, starting with the most recent. You can see the commit history here
feat: support multisig recursion
Allows multisig to function hierarchically, expected to be useful for e.g. automating organizational approval flows.
Tests:
feat: introduce multisig quorum and weights
Inspired by Sui's multisig. Allows for flexible, if not completely free, authentication policies beyond "m of n". For example, weight equivalent to quorum represents administrative privileges
feat: add multisig subcommand to client CLI
You can see more usage in the testing script
feat: introduce multisig transaction time-to-live
Considers the latest block timestamp as the current time and determines timeout, when the transactions registry is called
feat: predefine multisig world-level trigger in genesis
Defines a global trigger in genesis that exercises authority over all domains. There will be three types of triggers on the system side related to multisig:
feat: allow accounts in domain to register multisig accounts
Accounts registry has authority of the domain owner, so access was previously restricted. This commit allows anyone to organize any multisig account within the domain.
This may be too lenient. Discussion
Review notes
To get an overview,
The dotted line indicates an automatic process
Checklist
CONTRIBUTING.md
.