fix(torii): close ws properly in blocks/events stream - Githubissues

hyperledger-iroha / iroha

Iroha - A simple, enterprise-grade decentralized ledger

https://wiki.hyperledger.org/display/iroha

Apache License 2.0

438 stars 280 forks source link

fix(torii): close ws properly in blocks/events stream #5101

Closed Erigara closed 2 weeks ago

Erigara commented 1 month ago

Context

Closes #5004.

Problem was that iroha tried to unconditionally closed websocket by writing into it.

During another problems were discovered as well:

on client side sync and async websocket stream wasn't properly closed (not reads until handshake completion)
on client async websocket Stream implementation was incorrect by not registering itself on receiving non binary message

Solution

Fix mentioned problems + refactoring.