refactor: increase type safety of block lifecycle - Githubissues

hyperledger-iroha / iroha

Iroha - A simple, enterprise-grade decentralized ledger

https://wiki.hyperledger.org/display/iroha

Apache License 2.0

438 stars 280 forks source link

refactor: increase type safety of block lifecycle #5140

Closed mversic closed 2 weeks ago

mversic commented 2 weeks ago

Context

increased type safety around block creation
introduced new Created event for blocks
relaxed conditions for signature validation

Solution

Describe the approach taken to achieve the objective / resolve the issue.

Migration Guide (optional)

If this PR contains a breaking change relative to the main branch, provide an instruction on how affected parties might need to adapt to the change.

Review notes (optional)

For complex PRs, try to provide some information on how to approach the review more effectively.
For example, is there a natural order in which the affected files should be reviewed?

Checklist

[ ] I've read CONTRIBUTING.md.
[ ] (optional) I've written unit tests for the code changes.
[ ] All review comments have been resolved.
[ ] All CI checks pass.

0x009922 commented 1 week ago

This PR caused regression in tests in #5124, namely in extra_functional::genesis::*. irohad panics here:

https://github.com/hyperledger/iroha/blob/c1b8563086db77155d0c90e30bac14a1bc2a54a5/crates/iroha_core/src/sumeragi/main_loop.rs#L396