The bug is triggered if a a peer is unregistered from the topology while Sumeragi Messages are still in flight. This
is the only place where we use and array index operation that can panic. It is very hard to write a test for this case
that is guaranteed to show the issue each time.
Closes #5104
Solution
Describe the approach taken to achieve the objective / resolve the issue.
Migration Guide (optional)
If this PR contains a breaking change relative to the main branch, provide an instruction on how affected parties might need to adapt to the change.
Review notes (optional)
For complex PRs, try to provide some information on how to approach the review more effectively.
For example, is there a natural order in which the affected files should be reviewed?
Context
The bug is triggered if a a peer is unregistered from the topology while Sumeragi Messages are still in flight. This is the only place where we use and array index operation that can panic. It is very hard to write a test for this case that is guaranteed to show the issue each time.
Closes #5104
Solution
Migration Guide (optional)
main
branch, provide an instruction on how affected parties might need to adapt to the change.Review notes (optional)
Checklist
CONTRIBUTING.md
.