hyperledger-iroha / iroha

Iroha - A simple, enterprise-grade decentralized ledger
https://wiki.hyperledger.org/display/iroha
Apache License 2.0
438 stars 280 forks source link

fix: Add range check to signature index #5157

Closed SamHSmith closed 3 days ago

SamHSmith commented 1 week ago

Context

The bug is triggered if a a peer is unregistered from the topology while Sumeragi Messages are still in flight. This is the only place where we use and array index operation that can panic. It is very hard to write a test for this case that is guaranteed to show the issue each time.

Closes #5104

Solution

Migration Guide (optional)


Review notes (optional)

Checklist

mversic commented 1 week ago

what's the corresponding issue for this?

0x009922 commented 1 week ago

Linked it: #5104