search

hyperledger-iroha / iroha

Iroha - A simple, enterprise-grade decentralized ledger
https://wiki.hyperledger.org/display/iroha
Apache License 2.0
438 stars 280 forks source link

Move integration tests out of `iroha` #5168

Open mversic opened 1 week ago

mversic commented 1 week ago

We should remove integration tests from iroha into a separate crate. The reason is that those are not client integration tests but rather a full system tests. I propose that we move them into iroha_test_network and rename the iroha_test_network into iroha_test_suite or something similar

I would like to get your opinions here

0x009922 commented 3 days ago

I propose that we move them into iroha_test_network and rename the iroha_test_network into iroha_test_suite or something similar

iroha_test_network might in future replace current test_env.py if we make it an executable. This might be useful e.g. to re-use it in JS SDK tests and in other SDKs too. Renaming it to iroha_test_suite contradicts this intention.

Apart from that, I agree that integration tests are better to be in a separate place from the client.