New parameter was added (network.external_port in the config, or P2P_EXTERNAL_PORT env var). This parameter should contain external port of the peer used for p2p (as seen by other peers). Usually it equals port from existing parameter network.address (or P2P_ADDRESS env), but can be different in case peer is inside docker or behind reverse proxy.
Review notes (optional)
I split meaningful changes into second commit.
First commit contains refactoring related to Peer vs PeerId.
github-actions[bot]
commented
4 days ago
Context & Solution
Please see https://github.com/hyperledger/iroha/issues/5117#issuecomment-2414908987 for detailed description
Migration Guide (optional)
New parameter was added (
network.external_portin the config, orP2P_EXTERNAL_PORTenv var). This parameter should contain external port of the peer used for p2p (as seen by other peers). Usually it equals port from existing parameternetwork.address(orP2P_ADDRESSenv), but can be different in case peer is inside docker or behind reverse proxy.Review notes (optional)
I split meaningful changes into second commit. First commit contains refactoring related to
PeervsPeerId.TODO:
multiple_networks)Checklist
CONTRIBUTING.md.