hyperledger-iroha / iroha

Iroha - A simple, enterprise-grade decentralized ledger
https://wiki.hyperledger.org/display/iroha
Apache License 2.0
438 stars 280 forks source link

Move general-purpose crates to separate repositories #5180

Open mversic opened 3 days ago

mversic commented 3 days ago

This will have multiple benefits:

The following crates should be moved to separate repositories:

The following crates can also be argued to be moved to separate repos:

Don't publish these crates:

Important considerations

  1. All the crates should initially be versioned as 0.x.x to be able to make breaking changes. We want to see how they will grow before making a 1.x.x release.
  2. We want to keep commit history of the crates when moving them to separate repositories
  3. Consider renaming some of the crates. Preferably come up with Japanese terms
nxsaken commented 3 days ago

All the crates should initially be versioned as 0.x.x to be able to make breaking changes.

We can't do it in a uniform way because the existing iroha crate has already been published (and yanked). We agreed to publish it starting from 2.0.0, and having different versioning schemes would be complicated. I do agree that general-purpose crates like conststr can be published from 0.x.x. Eh, maybe it's fine

mversic commented 3 days ago

We can't do it in a uniform way because the existing iroha crate has already been published (and yanked).

I don't understand what this has to do with anything.

I do agree that general-purpose crates like conststr can be published from 0.x.x.

I specifically pulled these crates out because I consider them all general-purpose and not specifically related to iroha. They should be considered separate projects and have separate versioning. This is why I proposed to pull them into separate repositories so that other projects can use them as dependencies. Don't let the iroha_ prefix of these crates kid you, prefix should be removed when moving them into separate repos

nxsaken commented 2 days ago

Created repo stubs: