refactor(multisig)!: move from triggers to custom instructions

s8sato commented 3 weeks ago

Context

Calling a trigger with args as a multisig operation was not a clear interface
The multisig implementation as triggers introduced validation exceptions for registering and executing triggers to bridge the authority gap between the caller and the executor: #5027

Assign dedicated custom instructions to the multisig operations
Switch to the executor context and package validation and execution logics as the custom instructions

As a side benefit of removing triggers i.e. no event pools, recursive approvals immediately propagate without ticking time

Introduces MultisigRegister MultisigPropose MultisigApprove custom instructions that replace MultisigAccountArgs MultisigTransactionsArgs
Removes CanRegisterAnyTrigger CanUnregisterAnyTrigger permissions that become useless and are unlikely to be used
Though it becomes useless for multisig, retains the capability to register wasm triggers in genesis

github-actions[bot] commented 3 weeks ago

@BAStos525

s8sato commented 3 weeks ago

Self-reviewed and made fixes 4e4a6b9b3 0e4fc3a31 for now. I'm going to address your comments tomorrow @mversic

s8sato commented 2 weeks ago

Updates:

minor updates since https://github.com/hyperledger-iroha/iroha/pull/5217#pullrequestreview-2418103555
nonzero quorum and transaction_ttl_ms
replace host.submit with executor.visit_*
- resolves #5222
- keeps #5223

s8sato commented 2 weeks ago

Updates:

minor updates since https://github.com/hyperledger-iroha/iroha/pull/5217#issuecomment-2463859606
exclude custom instructions from schema types!
dedup and delegate MultisigRegister validation to execution

s8sato commented 2 weeks ago

Updates:

s8sato commented 1 week ago

Updates: