search

hyperledger-iroha / iroha

Iroha - A simple, enterprise-grade decentralized ledger
https://wiki.hyperledger.org/display/iroha
Apache License 2.0
444 stars 277 forks source link

Potential panic in default executor `visit_register_role` #5236

Open dima74 opened 1 week ago

dima74 commented 1 week ago

Looks like return should be added after executor.deny(err)? Otherwise execute! will panic in case if branch with executor.deny(err) is reached

https://github.com/hyperledger-iroha/iroha/blob/a90040ca930a960cddb4697d04962a1038f98219/crates/iroha_executor/src/default.rs#L1305-L1309