Infallible revoke of associated permissions on unregistering entities

hyperledger-iroha / iroha

Iroha - A simple, enterprise-grade decentralized ledger

https://wiki.hyperledger.org/display/iroha

Apache License 2.0

444 stars 277 forks source link

Infallible revoke of associated permissions on unregistering entities #5244

Open s8sato opened 6 days ago

s8sato commented 6 days ago

I don't think those revokes are currently expected to be infallible. For example, who CanUnregisterDomain can fail to revoke CanModifyDomainMetadata in visit_unregister_domain. Or we could consider this as a bug that should be eliminated in another issue, and make it panic or ValidationFail::InternalError

_Originally posted by @s8sato in https://github.com/hyperledger-iroha/iroha/pull/5239#discussion_r1846842131_